Fix loop variable in control value setting#271
Open
xkwy wants to merge 1 commit intotinyalsa:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the control value setting logic where a loop was using the wrong variable as its upper bound. When setting all control values to the same value, the loop should iterate over all control values (num_ctl_values) rather than the number of input values (num_values), which is always 1 in this code path.
- Changed loop condition from
num_valuestonum_ctl_valuesin the "set all values the same" code path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.