Disable speedups on GraalPy same as on PyPy#339
Conversation
etrepum
left a comment
There was a problem hiding this comment.
Would it also make sense to add graalpy to the CI matrix?
I didn't see PyPy in there, so I assumed it's not desired. Afaict the sdist is only tested against 3.13 and the cibuildwheel testing is done while skipping PyPy. I'm happy to enable tests against GraalPy and PyPy :) |
It builds and tests on all supported platforms, but the source tarball artifact uploaded to pypi as the sdist is only built once. Doesn't make sense to upload the same tarball N times. IIRC the pypy testing was removed because cibuildwheel isn't supporting it anymore but if there's a supported way to build and test with graal then I'd be happy to accept that. |
e0b6000 to
3eea9c5
Compare
|
Well, cibuildwheel does support building with PyPy and with GraalPy, but in general it does not support building pure Python wheels at all. And since the C code is not used on PyPy and GraalPy, cibuildwheel will refuse to build on those. (https://github.com/timfel/simplejson/actions/runs/17954795969/job/51063190663#step:4:2668) - so the only way is to add a test step for PyPy and GraalPy. |
|
testing those platforms in a separate job or jobs would be fine too |
etrepum
left a comment
There was a problem hiding this comment.
Looks great, thank you! Will merge after the CI suite has finished
With this change when building from source GraalPy does not receive the native extension (which does not help much, same as on PyPy)
Head branch was pushed to by a user without write access
Thanks. Python 2 has been too long, I forgot |
With this change when building from source GraalPy does not receive the native extension (which does not help much, same as on PyPy)