PEP 749: Use __format__ instead of .format as param name#3993
Closed
JelleZijlstra wants to merge 2 commits intopython:mainfrom
Closed
PEP 749: Use __format__ instead of .format as param name#3993JelleZijlstra wants to merge 2 commits intopython:mainfrom
JelleZijlstra wants to merge 2 commits intopython:mainfrom
Conversation
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 24, 2024
Larry Hastings pointed out that using an illegal parameter name makes it impossible to use inspect.signature() on annotate functions. Cross-ref python/peps#3993.
willingc
approved these changes
Sep 26, 2024
Contributor
willingc
left a comment
There was a problem hiding this comment.
Small wording suggestion @JelleZijlstra but good to merge as is too.
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Member
Author
|
We went with an alternative approach on Larry's suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @larryhastings @carljm
📚 Documentation preview 📚: https://pep-previews--3993.org.readthedocs.build/