Added Present's background color as an option to the Preferences window.#2568
Added Present's background color as an option to the Preferences window.#2568benfry merged 5 commits intoprocessing:masterfrom
Conversation
Sets present.bgcolor on clicking OK, sets color in Preferences window from Preferences.txt on opening the window.
Clicking on the color preview brings up a color selector; Inputting a hex color automatically previews it
Rm CustomColorChooser, add Cancel to ColorChooser, Formatting changes, Removed unnecessary listener, Inerchange preview color and text field.
Cursor to hand on mouseover & new border for color preview
|
Whoa, this is much more complicated than necessary. The color choosing is already implemented in the Export to Application dialog, it should only be a couple lines of code to add that to the Preferences window as well. |
|
Ben, it's a bit unclear to us how we should proceed. I propose:
OK? |
|
Perhaps I'm just confused by the commit. It looks like an entire new color chooser class has been added and removed. Or maybe there's a line endings problem that makes this look much larger? Check out the links for those commits... Maybe it's just a matter of re-doing the pull request so that I can see what's actually going on? |
|
Oh, you are looking at every single commit. That is not needed, just click "Files changed" at the top, that gives you the changes that will be applied in relation to the current code. And yes, Joel initially duplicated the color chooser and i asked him to reuse the one we already had instead. So it is actually not that much change in total. We can even slim it down further and make the style be concise if we make ColorPreference into a full class and use that instead of our own custom items. Should we do that? |
Added Present's background color as an option to the Preferences window.
|
Let's take the extra text field out of there and just have people click the color. It's extra complexity that's just not needed. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hey,
In these few commits, I've added an option for the user to conveniently choose a background color for Present from the Preferences window. This can be done in 2 ways:
The text field has been designed to accept a hex color of the form #xxxxxx and xxxxxx, (x- 0 to F), and auto-previews the color once the user enters a valid hex color.
A Cancel button has also been added to the ColorChooser, because it seemed like a nice feature to have for both the Color Selector tool, as well as for this particular application.
Thanks