refactor: change div to aside for accessibility in settings component#1003
Open
hxrshxz wants to merge 5 commits intoprocessing:mainfrom
Open
refactor: change div to aside for accessibility in settings component#1003hxrshxz wants to merge 5 commits intoprocessing:mainfrom
hxrshxz wants to merge 5 commits intoprocessing:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility by replacing a generic div element with a semantic aside element for the Settings component. The change adds proper landmark navigation support for screen reader users without affecting visual layout or functionality.
- Replaces
divwithasideelement for semantic HTML - Adds
aria-label="Settings"for better screen reader identification
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@coseeian Please have a look , thank you |
coseeian
approved these changes
Dec 30, 2025
Collaborator
coseeian
left a comment
There was a problem hiding this comment.
LGTM, I think aside tag is a decent choice here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #996
Description
I have changed the div to aside for accessibility in settings componen now it is contained in a semantic landmark and now screen reader users can efficiently navigate the page using landmark shortcuts.