Open
Conversation
Attempt to fix pre-commit#2424, which has incorrectly been marked as a duplicate of pre-commit#860
Author
|
Happy to fix/add tests if the approach seems reasonable |
taliastocks
commented
Mar 14, 2025
taliastocks
commented
Mar 14, 2025
taliastocks
commented
Mar 14, 2025
Member
|
"incorrectly marked as a duplicate" you're really not starting strong with trying to convince me to take your patch. please don't tell me how to run my project |
Author
My apologies. I appreciate your efforts, and we chose to use this project because of them. |
|
This is a good change, it fixes a real issue. I tested it locally and it works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #2424, which has been marked as a duplicate of #860 (does not fix all of the latter).