Fix: Fix installing dependencies in node v22#7381
Conversation
|
thanks @chaigh-uk - I'll try to prioritize review in the next cycle. |
| "bubleify": "^2.0.0", | ||
| "buffer": "^6.0.3", | ||
| "canvas": "^2.11.2", | ||
| "canvas": "^3.1.0", |
| "jasmine": "3.5.0", | ||
| "jasmine-core": "3.5.0", | ||
| "jsdom": "^24.1.1", | ||
| "jsdom": "^26.0.0", |
There was a problem hiding this comment.
jsdom v25 appears to improve security issues in regards to the "dangerously" option used by tasks/util/plotly_node.mjs
This dependency bump from v24 to v26 seems good to me.
|
@chaigh-uk Thanks very much for the PR. You could fetch upstream/master and then add a test titled
plotly.js/.circleci/config.yml Line 410 in 40f2221 You also need to add your new plotly.js/.circleci/config.yml Line 553 in 40f2221 Thank you! |
Thanks for taking a look @archmoj - I've had a go at this in 46e0277 |
|
💯 🙏 Many thanks @chaigh-uk for the smart addition of node 22 tests. It is interesting to see node v22 tests appear to run faster. It would be great if someone else from @plotly/plotly_js also help approve this PR. On another note @chaigh-uk used a pattern in 46e0277 that simplified testing in different container versions. IMHO - It would be of interest to apply similar pattern in other places in plotly.js and plotly.py and dash tests to reduce/avoid duplicated CircleCI config code |

Fixes #7306
Bumps
canvasto v3.1.0 andjsdomto v26.0.0The key fix was in canvas and is detailed here