Don't convert deprecations to exceptions#19933
Open
kamil-tekiela wants to merge 1 commit intophpmyadmin:masterfrom
Open
Don't convert deprecations to exceptions#19933kamil-tekiela wants to merge 1 commit intophpmyadmin:masterfrom
kamil-tekiela wants to merge 1 commit intophpmyadmin:masterfrom
Conversation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19933 +/- ##
============================================
+ Coverage 62.21% 62.25% +0.04%
+ Complexity 16170 16164 -6
============================================
Files 675 674 -1
Lines 60222 60198 -24
============================================
+ Hits 37467 37478 +11
+ Misses 22755 22720 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
williamdes
approved these changes
Dec 17, 2025
Member
williamdes
left a comment
There was a problem hiding this comment.
Looks good, but they will display ?
Contributor
Author
|
Currently this is how it shows up: With this PR this is how it will be: |
Member
|
Thanks, I better understand this PR now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #19932