[ticket/16169] Add support for record filtering in text reparser#5697
[ticket/16169] Add support for record filtering in text reparser#5697JoshyPHP wants to merge 1 commit intophpbb:masterfrom
Conversation
f161782 to
64e053a
Compare
|
The code is actually old; I haven't touched it in a while. After re-reading it, I think it's incomplete because the reparser manager looks like it needs to be updated |
2e1919d to
faad86e
Compare
|
@JoshyPHP any plans on this? |
|
@rxu Not in the foreseeable future, no. As I recall, the filtering stuff is done but there's something about the way resume data is saved that requires some change. I can't recall the specifics but I found that the manager didn't work the way I thought and I think it required more work than anticipated or maybe the way the data is saved in the database had to be changed which meant it needed a migration and/or some backward-incompatible change and I couldn't see it through. |
|
Should we close this then? |
faad86e to
159988e
Compare
|
Keep it open for now. I rebased it on current master (before that, the test suite failed due to an unrelated error) and I'll take a second pass sometime in the foreseeable future. |
8785204 to
8705eb2
Compare
|
@marc1706 I think this is about done There's a summary at https://area51.phpbb.com/phpBB/viewtopic.php?f=146&t=76626 |
8705eb2 to
fc8b256
Compare
This is against master
but the API is backward compatible.I lied, I don't think it is because of the manager.PHPBB3-16169
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-16169