Skip to content

Comments

Add requirements-testing.txt to sdist#780

Open
mtelka wants to merge 1 commit intopexpect:masterfrom
mtelka:requirements-testing
Open

Add requirements-testing.txt to sdist#780
mtelka wants to merge 1 commit intopexpect:masterfrom
mtelka:requirements-testing

Conversation

@mtelka
Copy link

@mtelka mtelka commented Nov 25, 2023

Fixes #768.

@Red-M
Copy link
Member

Red-M commented Oct 30, 2024

This will also need to be added to the package data files.

@mtelka
Copy link
Author

mtelka commented Oct 30, 2024

This will also need to be added to the package data files.

Why? My understanding is that either package_data or MANIFEST.in should work, but we do not need both.

@mtelka
Copy link
Author

mtelka commented Oct 30, 2024

The https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data says:

Note that the data files specified using the package_data option neither require to be included within a MANIFEST.in file, nor require to be added by a revision control system plugin.

@Red-M
Copy link
Member

Red-M commented Oct 30, 2024

Fair enough, I've never really looked at MANIFEST.in but bashrc.sh is also there too.
To be clear, I am happy with this as is but figured I'd ask just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdist is missing requirements-testing.txt

2 participants