Fix/declarative config no exceptions by Bhagirath00 · Pull Request #8079 · open-telemetry/opentelemetry-java

Bhagirath00 · 2026-02-13T06:35:30Z

Description:

This PR updates the DeclarativeConfigProperties API to return null instead of throwing a DeclarativeConfigException when a property exists but has a different data type than requested (e.g., calling getBoolean on a String value).

Changes:

In DeclarativeConfigProperties.java (API): Updated Javadocs for all getter methods to explicitly state that they return null on type mismatch.
In YamlDeclarativeConfigPropertiesTest.java (Tests): Added comprehensive verification tests to ensure that getString, getBoolean, getInt, getStructured, and getStructuredList all return null correctly when a type mismatch occurs.

Verification Results:

All tests in the incubator module passed successfully:

Unit Tests Verification Command: ./gradlew :sdk-extensions:incubator:test ...

Parallel Configuration Cache is an incubating feature.
Reusing configuration cache.

BUILD SUCCESSFUL in 5s
109 actionable tasks: 4 executed, 105 up-to-date
Configuration cache entry reused.

Code Style Check Command: ./gradlew spotlessCheck

Parallel Configuration Cache is an incubating feature.
Calculating task graph as no cached configuration is available for tasks: spotlessCheck

BUILD SUCCESSFUL in 11s
282 actionable tasks: 282 up-to-date
Configuration cache entry stored.

…cubator

codecov · 2026-02-13T06:41:17Z

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.34%. Comparing base (fff95e0) to head (153c5d1).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
...or/fileconfig/YamlDeclarativeConfigProperties.java	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8079      +/-   ##
============================================
+ Coverage     90.20%   90.34%   +0.13%     
+ Complexity     7592     7591       -1     
============================================
  Files           841      839       -2     
  Lines         22911    22838      -73     
  Branches       2288     2280       -8     
============================================
- Hits          20666    20632      -34     
+ Misses         1529     1498      -31     
+ Partials        716      708       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

api/incubator/src/main/java/io/opentelemetry/api/incubator/propagation/EnvironmentGetter.java

api/incubator/src/main/java/io/opentelemetry/api/incubator/propagation/EnvironmentSetter.java

...io/opentelemetry/sdk/extension/incubator/fileconfig/YamlDeclarativeConfigPropertiesTest.java

jack-berg · 2026-02-13T17:14:45Z

Verification Results:

No need to bloat the PR description with this type of data which the build checks already tell us ;)

MikeGoldsmith · 2026-02-16T12:30:59Z

Docs updates look good. I agree with @robsunday that the EnvironmentGetter/Setter don't need to be in this PR.

…nfig

Bhagirath00 · 2026-02-16T17:32:54Z

@robsunday @jack-berg
Addressed review feedback and cleaned up the PR branch.

MikeGoldsmith

Look good to me 🚀

robsunday

I still have some minor comments, but I approve this PR

robsunday · 2026-02-18T13:40:11Z

...ava/io/opentelemetry/sdk/extension/incubator/fileconfig/YamlDeclarativeConfigProperties.java

  @Nullable
  @Override
  public String getString(String name) {
+    Objects.requireNonNull(name, "name");


The only doubt I have here is that the result of getString(null) will be NPE with quite cryptic message "name".
Maybe the message should be a bit more descriptive? Like "Null configuration property name".
This applies to all changes below.

Good catch, updated the message to be more descriptive. Thanks!

robsunday · 2026-02-18T13:42:37Z

...cubator/src/main/java/io/opentelemetry/api/incubator/config/DeclarativeConfigProperties.java

-   * @throws DeclarativeConfigException if the property is not a valid scalar string
+   *     {@code name} has not been configured or is not a valid scalar string
   */
  default String getString(String name, String defaultValue) {


For consistency I'd recommend adding here also:
Objects.requireNonNull(defaultValue, "Null default value");

Makes sense, added the null check for defaultValue too.

Bhagirath00 · 2026-02-18T18:20:01Z

@robsunday Pushed the fixes based on your feedback.

Bhagirath00 added 2 commits February 12, 2026 18:18

Implement Environment Variable Context Propagation carriers in api/in…

df9a72b

…cubator

Update DeclarativeConfigProperties to return null on type mismatch

6eed41c

Bhagirath00 requested a review from a team as a code owner February 13, 2026 06:35

robsunday reviewed Feb 13, 2026

View reviewed changes

Bhagirath00 force-pushed the fix/declarative-config-no-exceptions branch from 43cad9b to 6eed41c Compare February 15, 2026 11:20

Address feedback: clean up branch and improve safety in DeclarativeCo…

2012cd9

…nfig

MikeGoldsmith approved these changes Feb 18, 2026

View reviewed changes

robsunday approved these changes Feb 18, 2026

View reviewed changes

Improve null check messages for config property name and default value

153c5d1

Conversation

Bhagirath00 commented Feb 13, 2026

Description:

Changes:

Verification Results:

Uh oh!

codecov bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jack-berg commented Feb 13, 2026

Uh oh!

MikeGoldsmith commented Feb 16, 2026

Uh oh!

Bhagirath00 commented Feb 16, 2026

Uh oh!

MikeGoldsmith left a comment

Choose a reason for hiding this comment

Uh oh!

robsunday left a comment

Choose a reason for hiding this comment

Uh oh!

robsunday Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Bhagirath00 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

robsunday Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Bhagirath00 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Bhagirath00 commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

codecov bot commented Feb 13, 2026 •

edited

Loading