feat: add OpenAPI 3.1 breaking change checker rules#796
Open
reuvenharrison wants to merge 1 commit intofeat/openapi-3.1-supportfrom
Open
feat: add OpenAPI 3.1 breaking change checker rules#796reuvenharrison wants to merge 1 commit intofeat/openapi-3.1-supportfrom
reuvenharrison wants to merge 1 commit intofeat/openapi-3.1-supportfrom
Conversation
Add checker rules for const field changes, webhook add/remove, and nullable type arrays (OpenAPI 3.1 style). Includes localized messages for en, es, pt-br, and ru. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/openapi-3.1-support #796 +/- ##
============================================================
- Coverage 89.34% 89.21% -0.14%
============================================================
Files 240 244 +4
Lines 12276 12505 +229
============================================================
+ Hits 10968 11156 +188
- Misses 860 894 +34
- Partials 448 455 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constvalues are modifiedComponentChangefor webhook-level diff reporting"null"is added/removed from type arrays, and detect nullable changes viatype: ["string", "null"]in existing nullable checkersNew files
checker/check_request_property_const_changed.go— request body/property const ruleschecker/check_response_property_const_changed.go— response body/property const ruleschecker/check_webhook_updated.go— webhook added/removed ruleschecker/nullable_type_utils.go— helpers for null type array detectionModified files
checker/check_request_property_type_changed.go— suppress null-only type changeschecker/check_response_property_type_changed.go— suppress null-only type changeschecker/check_request_parameters_type_changed.go— suppress null-only type changeschecker/check_request_property_became_not_nuallable.go— detect nullable via type arraychecker/check_response_property_became_nuallable.go— detect nullable via type arraychecker/rules.go— register 16 new rulesTest plan
go test ./... -count=1)go vetandgo fmtclean🤖 Generated with Claude Code