ENH: numpy.where: don't silently truncate Python scalars#30803
Open
SpecLad wants to merge 1 commit intonumpy:mainfrom
Open
ENH: numpy.where: don't silently truncate Python scalars#30803SpecLad wants to merge 1 commit intonumpy:mainfrom
SpecLad wants to merge 1 commit intonumpy:mainfrom
Conversation
Since NumPy 2.0, code like the following will cause a scalar value to be
truncated:
>>> np.where([False], np.array([1], dtype=np.uint8), 1000)
array([232], dtype=uint8)
(in NumPy 1.x, it would instead output a uint16 array)
This is dangerous, and inconsistent with other NumPy functions, e.g.:
>>> np.multiply(np.array([1], dtype=np.uint8), 1000)
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
np.multiply(np.array([1], dtype=np.uint8), 1000)
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OverflowError: Python integer 1000 out of bounds for uint8
Use `npy_update_operand_for_scalar` to bring the behavior of `where` in line
with other functions.
Closes numpy#27006.
6250249 to
a06dd77
Compare
Member
|
Ping @seberg since this is related to scalar promotion changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since NumPy 2.0, code like the following will cause a scalar value to be truncated:
(in NumPy 1.x, it would instead output a uint16 array)
This is dangerous, and inconsistent with other NumPy functions, e.g.:
Use
npy_update_operand_for_scalarto bring the behavior ofwherein line with other functions.Closes #27006.