fix(packageRelativePath): fix 'where' for file deps#142
Closed
larsgw wants to merge 2 commits intonpm:release-nextfrom
Closed
fix(packageRelativePath): fix 'where' for file deps#142larsgw wants to merge 2 commits intonpm:release-nextfrom
larsgw wants to merge 2 commits intonpm:release-nextfrom
Conversation
db63b89 to
b09bc8c
Compare
06cdf5b to
f957798
Compare
Fix 'where' for file deps. It makes more sense for the 'where' to be the directory the file is in (and was possibly built in) than it being the file itself, having no use whatsoever. See https://npm.community/t/3364
896149d to
31718e7
Compare
This was referenced Dec 12, 2019
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #95, #137
Fix 'where' for file deps. It makes more sense for the 'where' to be the
directory the file is in (and was possibly built in) than it being the
file itself, having no use whatsoever.
See https://npm.community/t/3364