test: avoid flaky debugger restart waits#61773
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
6dd9cf9 to
c3b82fc
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61773 +/- ##
=======================================
Coverage 89.73% 89.74%
=======================================
Files 675 675
Lines 204648 204648
Branches 39330 39323 -7
=======================================
+ Hits 183651 183652 +1
- Misses 13282 13293 +11
+ Partials 7715 7703 -12 π New features to boost your workflow:
|
c3b82fc to
87a24df
Compare
87a24df to
58aeec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stepCommand('restart')withcommand('restart')in:test/parallel/test-debugger-restart-message.jstest/parallel/test-debugger-run-after-quit-restart.jstest-debugger-restart-message, wait forDebugger attached.and prompt before asserting the listening message counttest-debugger-run-after-quit-restart, continue to assert behavior viawaitForInitialBreak()andbreakInfoContext
test-macOShas shown intermittent timeouts while waiting forBREAK_MESSAGEin restart-related debugger tests.In failing logs, reconnect succeeds (
Debugger attached.is printed), but the expectedbreak ... inline is not observed before timeout.Hypothesis
The flake is likely caused by a timing race in CLI output ordering around restart/reconnect:
stepCommand()requiresBREAK_MESSAGEto appearbreak ... inoutput is delayed or missed by this wait patternThis change does not claim to prove a single root cause. It may be related to timing behavior in
test/common/debugger.js, but this PR only narrows these two tests to a less fragile synchronization path aligned with what each test is actually verifying.Why this approach
BREAK_MESSAGEwait specifically forrestartTesting
out/Release/node test/parallel/test-debugger-restart-message.jsout/Release/node test/parallel/test-debugger-run-after-quit-restart.jsFixes: #61762