doc: add missing space#52360
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 4, 2024
AugustinMauroy:fix-typo
Merged
doc: add missing space#52360nodejs-github-bot merged 1 commit intonodejs:mainfrom AugustinMauroy:fix-typo
nodejs-github-bot merged 1 commit intonodejs:mainfrom
AugustinMauroy:fix-typo
Conversation
Collaborator
|
Review requested:
|
UlisesGascon
approved these changes
Apr 4, 2024
Member
|
@AugustinMauroy can you update the commit message?
|
Member
Author
I'm sorry, I had read this file but I didn't understand what should I put in this case. |
Member
|
I'd suggest changing the commit message (and PR title) to |
doc/contributing/api-documentation.md
Member
Author
|
thanks @tniessen |
aduh95
approved these changes
Apr 4, 2024
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
|
Landed in a63261c |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52360 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52360 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing small typo.