tools: allow local updates for llhttp#52085
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 30, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
RafaelGSS
approved these changes
Mar 19, 2024
marco-ippolito
approved these changes
Mar 30, 2024
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52085 ✔ Done loading data for nodejs/node/pull/52085 ----------------------------------- PR info ------------------------------------ Title tools: allow local updates for llhttp (#52085) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:local-llhttp-update -> nodejs:main Labels tools Commits 2 - tools: allow local updates for llhttp - tools: linted code Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/52085 Reviewed-By: Michael Dawson Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52085 Reviewed-By: Michael Dawson Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 14 Mar 2024 15:50:21 GMT ✔ Approvals: 3 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1943813612 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52085#pullrequestreview-1945936095 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52085#pullrequestreview-1969860145 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52085 From https://github.com/nodejs/node * branch refs/pull/52085/merge -> FETCH_HEAD ✔ Fetched commits as 7c02486f1f91..c08c98b4692d -------------------------------------------------------------------------------- [main 6dcecc3b9a] tools: allow local updates for llhttp Author: Paolo Insogna Date: Thu Mar 14 16:48:20 2024 +0100 1 file changed, 29 insertions(+), 12 deletions(-) [main a4cc53b0e6] tools: linted code Author: Paolo Insogna Date: Fri Mar 15 08:18:57 2024 +0100 2 files changed, 6 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/8489560058 |
Collaborator
|
Landed in 021cf91 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52085 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52085 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to specify a local folder to update llhttp.
This is especially beneficial in security releases.