lib: return boolean result of assert.match method#35115
lib: return boolean result of assert.match method#35115juanarbol wants to merge 2 commits intonodejs:masterfrom
assert.match method#35115Conversation
The `assert.match` method by default will throws if there is no match, this change can add the function of instead of throwing or not, returns the boolean result of match. Fixes: nodejs#33869
|
I think this effectively just gives you the same result as I would suggest either closing #33869 as wontfix – I agree with the concern voiced by the author that this would be unexpected for an assertion method – or following @lundibundi’s suggestion there and making all the underlying assertion mechanisms available as separate methods, not just |
:O haha, this is true...
That really make sense to my. |
|
Closing this, this is almost like |
The
assert.matchmethod by default will throws if there is no match,this change can add the function of instead of throwing or not, returns
the boolean result of match.
Fixes: #33869
Note: I'm going to leave the documentation as a TODO :)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes