Skip to content

doc: document behavior for once(ee, 'error')#34225

Closed
jasnell wants to merge 2 commits intonodejs:masterfrom
jasnell:fix-for-31244
Closed

doc: document behavior for once(ee, 'error')#34225
jasnell wants to merge 2 commits intonodejs:masterfrom
jasnell:fix-for-31244

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Jul 6, 2020

Fixes: #31244

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jul 6, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
trivikr
trivikr previously requested changes Jul 9, 2020
View reviewed changes
@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2020
lpinca
lpinca reviewed Jul 9, 2020
View reviewed changes
@jasnell @lpinca
[squash] nit
fe70691 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2020
jasnell added a commit that referenced this pull request Jul 9, 2020
@jasnell
doc: document behavior for once(ee, 'error')
949d1c1 
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member Author

jasnell commented Jul 9, 2020

Landed in 949d1c1

@jasnell jasnell closed this Jul 9, 2020
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@jasnell @MylesBorins
doc: document behavior for once(ee, 'error')
e77213c 
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@jasnell @MylesBorins
doc: document behavior for once(ee, 'error')
ffe6886 
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Sep 27, 2020
@jasnell @codebytere
doc: document behavior for once(ee, 'error')
04967a6 
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@jasnell @addaleax
doc: document behavior for once(ee, 'error')
a9f0fc9 
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr left review comments

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify behaviour when listening for 'error' event using once()

5 participants

@jasnell @addaleax @lpinca @trivikr @nodejs-github-bot

Comments