Skip to content

test: mark test-http2-reset-flood flaky on bsd#32595

Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:test-http2-reset-flood-flaky
Lines changed: 2 additions & 0 deletions
Closed

test: mark test-http2-reset-flood flaky on bsd#32595
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:test-http2-reset-flood-flaky

Conversation

@MylesBorins
Copy link
Contributor

This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

Unverified

The email in this signature doesn’t match the committer email.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: nodejs#29802
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30321/ (:heavy_check_mark:)

@MylesBorins
Copy link
Contributor Author

Fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 1, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020

Unverified

The email in this signature doesn’t match the committer email.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in 9d82c55

@MylesBorins MylesBorins closed this Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020

Unverified

The email in this signature doesn’t match the committer email.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Apr 3, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020

Unverified

The committer email address is not verified.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020

Partially verified

This commit is signed with the committer’s verified signature.
targos’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.

Refs: #29802

PR-URL: #32595
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github added a commit to sam-github/node that referenced this pull request Apr 13, 2020
sam-github added a commit that referenced this pull request Apr 14, 2020
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020

Unverified

The email in this signature doesn’t match the committer email.
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
Refs: nodejs#29802
Refs: nodejs#32595

PR-URL: nodejs#32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
Refs: #29802
Refs: #32595

PR-URL: #32825
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

Comments