Closed
Conversation
Member
Author
|
cc @nodejs/assert @nodejs/repl @nodejs/util @joyeecheung @bcoe @BridgeAR gosh i hope that's everyone whose stuff was touched |
8 tasks
jasnell
reviewed
Sep 30, 2019
bcoe
approved these changes
Sep 30, 2019
cjihrig
approved these changes
Sep 30, 2019
BridgeAR
reviewed
Oct 1, 2019
Member
BridgeAR
left a comment
There was a problem hiding this comment.
It would be great to add a custom eslint rule to error on all prepareStackTrace() usages. Otherwise it's probably difficult to prevent new ones sneaking in. The warning could then reference internalOverridenErrors.
lib/internal/errors.js
Outdated
Member
There was a problem hiding this comment.
Nit: maybe use at least fn to indicate it's a function (that's how we mostly named them throughout the code)?
2cddcf3 to
d5b9913
Compare
d5b9913 to
93058ba
Compare
Collaborator
Member
|
Landed in 70c2444 |
Trott
pushed a commit
that referenced
this pull request
Oct 2, 2019
PR-URL: #29777 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #29777 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
2 tasks
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
It relies on nodejs/node#29777, and we don't override prepareStackTrace.
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis removes the dependency on
prepareStackTracefrom node internals for #29564