Add SharedArrayBuffer to Buffer documentation#15489
Closed
ThomasdenH wants to merge 5 commits intonodejs:masterfrom
Closed
Add SharedArrayBuffer to Buffer documentation#15489ThomasdenH wants to merge 5 commits intonodejs:masterfrom
ThomasdenH wants to merge 5 commits intonodejs:masterfrom
Conversation
lpinca
reviewed
Sep 20, 2017
doc/api/buffer.md
Outdated
Member
There was a problem hiding this comment.
Can you please move this line to keep the alphabetical order?
Contributor
Author
|
Done. I can rebase the commits if you prefer. |
Member
|
No, it's fine, commits are squashed before landing. Thank you. |
joyeecheung
approved these changes
Sep 20, 2017
cjihrig
approved these changes
Sep 20, 2017
TimothyGu
reviewed
Sep 20, 2017
doc/api/buffer.md
Outdated
Member
There was a problem hiding this comment.
Can you change {ArrayBuffer} to {ArrayBuffer|SharedArrayBuffer} as well?
| When `string` is a `Buffer`/[`DataView`]/[`TypedArray`]/[`ArrayBuffer`], the | ||
| actual byte length is returned. | ||
| When `string` is a `Buffer`/[`DataView`]/[`TypedArray`]/[`ArrayBuffer`]/ | ||
| [`SharedArrayBuffer`], the actual byte length is returned. |
doc/api/buffer.md
Outdated
jasnell
approved these changes
Sep 20, 2017
BridgeAR
approved these changes
Sep 24, 2017
Member
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM with the comments addressed.
Contributor
Author
|
I've addressed the comments. |
BridgeAR
reviewed
Sep 24, 2017
doc/api/buffer.md
Outdated
Member
There was a problem hiding this comment.
The line length is above 80 chars.
BridgeAR
reviewed
Sep 24, 2017
doc/api/buffer.md
Outdated
Member
There was a problem hiding this comment.
The line length is above 80 chars.
BridgeAR
reviewed
Sep 24, 2017
doc/api/buffer.md
Outdated
Member
There was a problem hiding this comment.
The line length is above 80 chars.
Member
|
Ping @ThomasdenH this needs a rebase and please address the comments about the line length. |
Member
Member
|
@ThomasdenH ... can I ask you to please squash the commits down into a single commit |
Member
|
Linter CI after rebase and squash: https://ci.nodejs.org/job/node-test-linter/13860/ Edit: CI timed out. New try: https://ci.nodejs.org/job/node-test-linter/13861/ |
targos
approved these changes
Nov 23, 2017
Member
|
Landed in bd0e36d |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #15489 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2a2ec9d,
Bufferaccepts aSharedArrayBufferin places whereArrayBufferwas accepted previously. This PR updates the documentation accordingly.Note that not every occurrence was replaced. In most cases it seems clear from the context that both are accepted, although some might disagree about this.
make -j4 test(UNIX), orvcbuild test(Windows) passes