test: move common.PORT tests to sequential#15151
Closed
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-comon-port-2
Closed
test: move common.PORT tests to sequential#15151maclover7 wants to merge 2 commits intonodejs:masterfrom maclover7:jm-comon-port-2
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-comon-port-2
Conversation
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use -` test-dgram-implicit-bind-failure` requires hardcoded port number to properly send socket packet - `test-http-agent-uninitialized-with-handle` requires hardcoded port number to properly send http request - `test-http-agent-uninitialized` requires hardcoded port number to properly send http request - `test-net-localport` requires hardcoded port number for assertions
Member
|
I think the http agent tests can be refactored to use a random available port. |
Member
@maclover7 if you're up for this then great, otherwise I think it can probably be done in a follow-on PR. |
Contributor
Author
lpinca
reviewed
Sep 3, 2017
| res.end(); | ||
| })).listen(common.PORT, common.mustCall(() => { | ||
| })).listen(0, common.mustCall(() => { | ||
| const req = new http.ClientRequest(`http://localhost:${server.address().port}/`); |
Member
There was a problem hiding this comment.
Nit: long line I guess linter is not happy :)
Member
There was a problem hiding this comment.
Linter probably forgives it because it contains a URL. But it should probably be wrapped.
Contributor
Author
There was a problem hiding this comment.
make lint runs with no errors -- nothing to do here I guess? I know the line is 83 chars long, is it worth it move the URL string to a new line?
gibfahn
approved these changes
Sep 3, 2017
cjihrig
approved these changes
Sep 3, 2017
lpinca
approved these changes
Sep 8, 2017
Member
Member
|
Landed in af15b75 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Sep 11, 2017
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use. - `test-dgram-implicit-bind-failure` requires a hardcoded port number to properly send socket packet. - `test-http-agent-uninitialized-with-handle` requires a hardcoded port number to properly send http request. - `test-http-agent-uninitialized` requires a hardcoded port number to properly send http request. - `test-net-localport` requires a hardcoded port number for assertions. In addition this replaces two common.PORTs with a dynamic port. PR-URL: nodejs#15151 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use. - `test-dgram-implicit-bind-failure` requires a hardcoded port number to properly send socket packet. - `test-http-agent-uninitialized-with-handle` requires a hardcoded port number to properly send http request. - `test-http-agent-uninitialized` requires a hardcoded port number to properly send http request. - `test-net-localport` requires a hardcoded port number for assertions. In addition this replaces two common.PORTs with a dynamic port. PR-URL: nodejs#15151 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
Reasons: - `test-async-wrap-getasyncid` binds a handle, so move to sequential because port cannot be already in use. - `test-dgram-implicit-bind-failure` requires a hardcoded port number to properly send socket packet. - `test-http-agent-uninitialized-with-handle` requires a hardcoded port number to properly send http request. - `test-http-agent-uninitialized` requires a hardcoded port number to properly send http request. - `test-net-localport` requires a hardcoded port number for assertions. In addition this replaces two common.PORTs with a dynamic port. PR-URL: #15151 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons:
test-async-wrap-getasyncidbinds a handle, so move to sequential because port cannot be already in use-
test-dgram-implicit-bind-failurerequires hardcoded port number to properly send socket packettest-net-localportrequires hardcoded port number for assertionsThis PR also updates
test-http-agent-uninitializedandtest-http-agent-uninitialized-with-handleto not usecommon.PORTanymore.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test