Skip to content

fix(session-mixing): capabilities npe #16452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alperozturk96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(session-mixing): capabilities npe #16452

alperozturk96 wants to merge 1 commit into from

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 5, 2026 •
edited by joshtrichards
Loading

  • Tests written, or not not needed

Fixes #16451

Fixes #14653

Changes

Makes OCCapability non-nullable
Checks and logs existince of it

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Feb 5, 2026

/backport to stable-3.36

@alperozturk96 alperozturk96 linked an issue Feb 5, 2026 that may be closed by this pull request
NPE on OCCapability.getAssistant() #16451
Open
4 tasks
@alperozturk96
fix(session-mixing): capabilities npe
3ca50ec 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/session-mix-oc-capability-npe branch from 0b7648d to 3ca50ec Compare February 9, 2026 11:28
@nextcloud nextcloud deleted a comment from github-actions bot Feb 9, 2026
@alperozturk96 alperozturk96 linked an issue Feb 9, 2026 that may be closed by this pull request
start Nextcloud on Android 12 => Crash #16458
Open
4 tasks
@alperozturk96 alperozturk96 mentioned this pull request Feb 9, 2026
Open
4 tasks
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7474
Dodgy code257257
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4444
Security1818
Total479479

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16452.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

AndyScherzinger
AndyScherzinger approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Feb 10, 2026

I think this is the wrong idea to fix it:
When app is working in normal state, then it must have user and capability.
If for some reason, one of them is not available, then we need to fix it there (or prevent a call to it).

But neither user nor capability are optional and must always exist (same like e.g. server url, etc).

tobiasKaminsky
tobiasKaminsky requested changes Feb 10, 2026
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

No milestone

3 participants

@alperozturk96 @tobiasKaminsky @AndyScherzinger