feat: support stderr logging in Jupyter notebook environments#2020
Open
BabyChrist666 wants to merge 5 commits intomodelcontextprotocol:mainfrom
Open
feat: support stderr logging in Jupyter notebook environments#2020BabyChrist666 wants to merge 5 commits intomodelcontextprotocol:mainfrom
BabyChrist666 wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
Fixes modelcontextprotocol#156 In Jupyter notebook environments, passing sys.stderr directly to subprocess doesn't work as expected - the stderr output is lost and users have no visibility into server errors or crashes. This change: - Adds _is_jupyter_environment() to detect when running in Jupyter/IPython - In Jupyter mode, captures stderr as a pipe and reads it asynchronously - Prints stderr output with red ANSI color for visibility in notebooks - In non-Jupyter environments, behavior remains unchanged (direct stderr) The fix ensures that MCP server error messages and crash logs are visible in Jupyter notebooks, making debugging much easier. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Please fix CI before we review. |
…pport - Add missing blank line after _is_jupyter_environment function (ruff E302) - Change triple-quoted strings from ''' to """ in tests (ruff Q000) - Remove unused Callable import - Remove dead code branch in stderr_reader (non-Jupyter path was unreachable) - Add tests for _is_jupyter_environment with mocked IPython (IPKernelApp, ZMQInteractiveShell) - Add tests for stderr_reader in Jupyter mode with mocked _is_jupyter_environment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused Union import in win32/utilities.py, use | syntax - Add test for get_ipython() returning None (covers 43->52 branch) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add type: ignore comments for IPython imports (reportMissingImports, etc.) - Add pragma: no branch for async context manager branches in Jupyter tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #156
In Jupyter notebook environments, passing
sys.stderrdirectly to subprocess doesn't work as expected - the stderr output is lost and users have no visibility into server errors or crashes. This makes debugging extremely difficult as the notebook cell just hangs with no feedback.Changes
_is_jupyter_environment()function to detect Jupyter/IPython notebook environmentsHow It Works
capture_stderr=Truewhich pipes stderr instead of redirectingstderr_readertask reads the pipe and prints to the notebook outputTechnical Details
IPKernelAppin config orZMQInteractiveShellclass nameTest plan
TestJupyterStderrSupporttest class with 4 tests🤖 Generated with Claude Code