TST: Use explicit style in all image_comparison calls#31148
Open
QuLogic wants to merge 2 commits intomatplotlib:mainfrom
Open
TST: Use explicit style in all image_comparison calls#31148QuLogic wants to merge 2 commits intomatplotlib:mainfrom
QuLogic wants to merge 2 commits intomatplotlib:mainfrom
Conversation
If a single extension is being tested, then as a shortcut, it can be specified in the basename directly. Also, the default for `check_figures_equal` is to test only `.png` now, so no need to specify that.
This makes it so that future tests *must* use the new style (or explicitly opt in to the old), and in the future, we may return to a default of that one instead. Fixes matplotlib#24716
5ac6017 to
85a4a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This makes it so that future tests must use the new style (or explicitly opt in to the old), and in the future, we may return to a default of that one instead.
I used a
libcsttransform to add the kwarg in alphabetical order, so some bits of the diff might be suboptimal in their succinctness, but they should be all consistent.Fixes #24716
This is based on #31137.
PR checklist