Fix issue with sketch not working on PathCollection in Agg#25645
Fix issue with sketch not working on PathCollection in Agg#25645QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
49b3d47 to
b235cbb
Compare
|
Can you try an image test? I think they're recreatable if you use a fixed seed? |
|
We can only control the seed for data generation in NumPy, not the seed for the C++-part. However, there is #13479 which is related. |
|
yeah, I agree with Jody that #13479 (comment) is the correct solution (and also probably out of scope here) |
|
I've realized that sketching is in general not tested that well (if at all). However, although the result is (probably) deterministic at the moment, I think that it is better to add tests as part of implementing seeding. |
QuLogic
left a comment
There was a problem hiding this comment.
This looks reasonable, but I guess it needs rebase to refresh CI?
|
@oscargus please rebase |
Will sort it out over the weekend. |
b235cbb to
1cd9255
Compare
|
No conflicts during rebase (but apparently a very long/short weekend...). |
PR Summary
Closes #19693
Seems like sketch was not handled at all for path collections.
Maybe not the nicest code, but my C/C++ is not that good.
If I understand it correctly, sketch isn't really tested (as it is hard to recreate the images?)?
Here is the output anyway:
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst