Fix remove_duplicates function to handle binary values#918
Closed
ca20110820 wants to merge 3 commits intokeon:masterfrom
Closed
Fix remove_duplicates function to handle binary values#918ca20110820 wants to merge 3 commits intokeon:masterfrom
ca20110820 wants to merge 3 commits intokeon:masterfrom
Conversation
1 and True are treated the same 0 and False are treated the same
Owner
|
Thanks for the bug fix! The repo was restructured in v1.0.0. Closing as the changes no longer apply cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue (originally found in unit test run) where the binary values for
1andTrue(0andFalse) are treated equally for this function.Changes
remove_duplicates(array)function.remove_duplicates(array)function.test_summarize_ranges()method in the same test script (test_array.py)