Open
Conversation
added 4 commits
January 24, 2026 19:20
Maybe connect() will succeed because it doesn't actually send out any packets, but sendmsg() fails because the packet couldn't go out for some reason (e.g., arp failure) or v6 route was lost in the time between connect() and sendmsg(). heimdal#1304
Noticed as part of: - heimdal#1286 - heimdal#1304
The duration between consecutive queries to gss_cred_inquire may not be exactly zero, so the remaining lifetime in seconds may have decremented by the time we do the second check. Rather than require instantaneous execution of the test logic, which was already noted in a comment to be racy, just require that the change in lifetimes be no more than the change in time elapsed.
Contributor
|
I'll take a look after #1309 is fixed (can't run the Linux GHA workflows otherwise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make some GSSAPI tests more robust so it doesn't spuriously fail if we get a little unlucky about timing.