Skip to content

Loose ends from #1304#1312

Open
riastradh wants to merge 4 commits intoheimdal:masterfrom
riastradh:riastradh-issue1304-kpasswdbugs
Open

Loose ends from #1304#1312
riastradh wants to merge 4 commits intoheimdal:masterfrom
riastradh:riastradh-issue1304-kpasswdbugs

Conversation

@riastradh
Copy link

Also make some GSSAPI tests more robust so it doesn't spuriously fail if we get a little unlucky about timing.

Taylor R Campbell added 4 commits January 24, 2026 19:20
Maybe connect() will succeed because it doesn't actually send out any
packets, but sendmsg() fails because the packet couldn't go out for
some reason (e.g., arp failure) or v6 route was lost in the time
between connect() and sendmsg().

heimdal#1304
The duration between consecutive queries to gss_cred_inquire may not
be exactly zero, so the remaining lifetime in seconds may have
decremented by the time we do the second check.

Rather than require instantaneous execution of the test logic, which
was already noted in a comment to be racy, just require that the
change in lifetimes be no more than the change in time elapsed.
@nicowilliams
Copy link
Contributor

I'll take a look after #1309 is fixed (can't run the Linux GHA workflows otherwise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants