Skip to content

samples(storage): add samples for soft delete objects #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shubham-up-47 merged 10 commits into from
Jun 7, 2025
Merged

samples(storage): add samples for soft delete objects #1486

shubham-up-47 merged 10 commits into from
Jun 7, 2025

Conversation

@shubham-up-47
Copy link
Contributor

@shubham-up-47 shubham-up-47 commented May 20, 2025 •
edited by cojenco
Loading

Add samples for object soft delete,

  • storage_disable_soft_delete
  • storage_get_soft_delete_policy
  • storage_set_soft_delete_policy
  • storage_list_soft_deleted_objects
  • storage_list_soft_deleted_object_versions
  • storage_restore_object

Fixes #1391

@shubham-up-47 shubham-up-47 requested review from a team as code owners May 20, 2025 09:06
@shubham-up-47 shubham-up-47 requested a review from gericdong May 20, 2025 09:06
@snippet-bot
Copy link

snippet-bot bot commented May 20, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels May 20, 2025
cojenco
cojenco reviewed May 30, 2025
View reviewed changes
cojenco
cojenco reviewed May 30, 2025
View reviewed changes
@shubham-up-47 shubham-up-47 requested a review from cojenco May 30, 2025 06:07
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 30, 2025
cojenco
cojenco reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise LGTM. Feel free to let me know if you have any questions

@shubham-up-47 shubham-up-47 requested a review from cojenco June 3, 2025 09:53
cojenco
cojenco previously approved these changes Jun 5, 2025
View reviewed changes
@shubham-up-47 shubham-up-47 requested a review from cojenco June 6, 2025 09:25
@cojenco cojenco added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 6, 2025
@shubham-up-47 shubham-up-47 merged commit 4e9b714 into googleapis:main Jun 7, 2025
14 checks passed
@shubham-up-47 shubham-up-47 deleted the soft_delete_samples branch June 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gericdong gericdong Awaiting requested review from gericdong gericdong is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@cojenco cojenco cojenco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cojenco cojenco

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Samples for object soft delete

2 participants

@shubham-up-47 @cojenco