samples: Add samples for soft_deleted_buckets #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
JesseLovelace
previously requested changes
Apr 16, 2025
Contributor
JesseLovelace
left a comment
There was a problem hiding this comment.
All samples need to have tests, please add them
Collaborator
Author
Done. @JesseLovelace Please check. |
bajajneha27
approved these changes
Apr 30, 2025
bajajneha27
left a comment
There was a problem hiding this comment.
Overall LGTM from feature perspective, just two nit comments.
cojenco
approved these changes
May 1, 2025
Contributor
cojenco
left a comment
There was a problem hiding this comment.
A few comments and questions, otherwise LGTM too
holtskinner
approved these changes
May 5, 2025
Already got approvals from 3 People.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
yes - Samples for Bucket Restore #1455
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
No source code changed.
Appropriate docs were updated (if necessary) - NA
Fixes #1455