Skip to content

feat: add support for soft delete#1229

Merged
cojenco merged 7 commits intogoogleapis:mainfrom
cojenco:softdelete
Mar 18, 2024
Merged

feat: add support for soft delete#1229
cojenco merged 7 commits intogoogleapis:mainfrom
cojenco:softdelete

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Feb 22, 2024

As part of the soft delete feature, add support to

  • Set a soft delete policy on a new or existing bucket
  • Get a bucket's soft delete policy
  • Get a soft deleted object by doing an object get call with the soft deleted parameter set to true
  • Get the soft delete time and hard delete time metadata fields from a soft deleted object
  • List soft deleted objects by doing an object list call with the soft deleted parameter set to true
  • Restore a soft deleted object

Fixes #1224

@cojenco cojenco requested review from a team as code owners February 22, 2024 23:03
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Feb 22, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2024
JesseLovelace
JesseLovelace reviewed Feb 26, 2024
View reviewed changes
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2024
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2024
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2024
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2024
@JesseLovelace JesseLovelace removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 13, 2024
andrewsg
andrewsg requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an answer to the question about behavior before I can continue with the review. Thanks!

vishwarajanand
vishwarajanand reviewed Mar 18, 2024
View reviewed changes
andrewsg
andrewsg requested changes Mar 18, 2024
View reviewed changes
@cojenco cojenco requested a review from andrewsg March 18, 2024 18:04
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2024
andrewsg
andrewsg approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco merged commit 3928aa0 into googleapis:main Mar 18, 2024
@release-please release-please bot mentioned this pull request Mar 18, 2024
Merged
@cojenco cojenco deleted the softdelete branch October 30, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

+2 more reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement soft delete

5 participants

@cojenco @andrewsg @vishwarajanand @JesseLovelace @yoshi-kokoro