chore: remove string replacement in owlbot.py#469
chore: remove string replacement in owlbot.py#469gcf-merge-on-green[bot] merged 4 commits intomasterfrom
Conversation
PiperOrigin-RevId: 389879008 Source-Link: googleapis/googleapis@7b6a2ce Source-Link: googleapis/googleapis-gen@3443eec
|
@parthea Why did you set this as "do not merge"? |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I renamed the PR title as the feature was already added in #456 |
|
@plamut Please can you take a look? |
|
On it. (the Pub/Sub Lite samples failure looks legitimate, though, missing method |
There was a problem hiding this comment.
It seems good, although not sure why that that Pub/Sub Lite failure all of a sudden... needs to be fixed if re-rerunning the tests does not work.
Update: Hmm... AdminClient is something from the Pub/Sub Lite repo, and if it's now missing the seek_subscription() method, it needs to be fixed there.
|
The fialing Pub/Sub Lite sample is for the code that had not been released yet at the time, but now a new version of Pub/Sub Lite has been released. Re-running the checks. |
PiperOrigin-RevId: 389879008
Source-Link: googleapis/googleapis@7b6a2ce
Source-Link: https://github.com/googleapis/googleapis-gen/commit/3443eecd0187f36db1324e5ab40ba9eef7b78b54