Skip to content

chore: clean up to_gbq testing and doc#968

Open
mattyopl wants to merge 2 commits intogoogleapis:mainfrom
mattyopl:dev2
Open

chore: clean up to_gbq testing and doc#968
mattyopl wants to merge 2 commits intogoogleapis:mainfrom
mattyopl:dev2

Conversation

@mattyopl
Copy link
Contributor

@mattyopl mattyopl commented Sep 9, 2024

address post-merge comments on #941

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mattyopl mattyopl requested a review from shobsi September 9, 2024 14:05
@mattyopl mattyopl self-assigned this Sep 9, 2024
@mattyopl mattyopl requested review from a team as code owners September 9, 2024 14:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants