Conversation
…ault to `None` to allow omitting them when type annotations are present
tswast
commented
May 29, 2024
| ) | ||
| import datetime | ||
|
|
||
| import bigframes_vendored.constants |
Collaborator
Author
There was a problem hiding this comment.
Moved to avoid circular dependencies since unfortunately import bigframes.constants implies import bigframes; import bigframes.constants.
TrevorBergeron
approved these changes
May 29, 2024
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: set
bpd.remote_function()sinput_typesandoutput_typesdefault toNoneto allow omitting them when type annotations are present (#729)END_COMMIT_OVERRIDE
Follow-up to #717 which made these parameters optional but forgot to add default values.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 343447415
🦕