Merged
Conversation
Towards internal issue 332735129
4 tasks
ashleyxuu
reviewed
May 7, 2024
Contributor
ashleyxuu
left a comment
There was a problem hiding this comment.
The samples and lints are still failing. I assume you're still working on it?
Collaborator
Author
Yeah. They pass locally, but I think I need to add some permissions to the connections, but I noticed there are way too many connections in the test project, so addressing that in GoogleCloudPlatform/python-docs-samples#11721 |
Collaborator
Author
|
Internal change CL 631539944 to add the admin permissions necessary to use the remote functions sample code. |
tswast
commented
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #664 where samples lint is failing.
🦕