feat: Support axis=1 in df.apply for scalar outputs#629
Merged
Conversation
TrevorBergeron
requested changes
Apr 25, 2024
TrevorBergeron
approved these changes
May 10, 2024
tswast
reviewed
May 17, 2024
| # in the remote function | ||
| # NOTE: Keep in sync with the value converters used in the gcf code | ||
| # generated in generate_cloud_function_main_code in remote_function.py | ||
| remote_function_supported_dtypes = ( |
Collaborator
There was a problem hiding this comment.
Ideally we'd document these limitations, too, right?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
remote_functiondoc https://screenshot.googleplex.com/4c6ZojpEYf7Wymjinput_typehttps://screenshot.googleplex.com/8TZGXJLw8rewd6WDataFrame.applyhttps://screenshot.googleplex.com/9jLWmQNUYpoVrTADataFrame.applyhttps://screenshot.googleplex.com/7nHi5ZjsGyTruToFixes internal issue 320674749 🦕