Merged
Conversation
TrevorBergeron
approved these changes
Mar 26, 2024
bigframes/dataframe.py
Outdated
Comment on lines
2088
to
2091
| if isinstance(index, blocks.Label): | ||
| index = [index] | ||
| else: | ||
| index = list(index) |
Contributor
There was a problem hiding this comment.
Does this have the correct behavior for tuples? Tuples are tricky because they can be interpreted as individual labels or list of labels.
shobsi
reviewed
Mar 29, 2024
| ... columns='Region' | ||
| ... ) | ||
| >>> pivot_table | ||
| Rating Sales |
Contributor
There was a problem hiding this comment.
#[nit] is the indentation alright here, also below?
|
|
||
| columns (str or object or a list of str): | ||
| Column to use to make new frame's columns. | ||
| aggfunc (str, default "mean"): |
Contributor
There was a problem hiding this comment.
[nit] no newline like after other params
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("values", "index", "columns", "aggfunc"), |
Contributor
There was a problem hiding this comment.
can we also test for the default values of these params?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
e264a0a to
a605890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Docs screenshot:
https://screenshot.googleplex.com/3FC5wP45SBFnPXi
https://screenshot.googleplex.com/BPfCJ6a5caWdvbi
https://screenshot.googleplex.com/Bd9XqEFv8X2d4sw
Fixes #<issue_number_goes_here> 🦕