fix!: exclude remote models for .register()#465
Merged
Conversation
ashleyxuu
approved these changes
Mar 19, 2024
Contributor
ashleyxuu
left a comment
There was a problem hiding this comment.
Any reason we want to exclude remote models .register() for LLM class?
Contributor
Author
Those remote models can be registered, but can't be deployed in Vertex. There was a discrepancy in BQML that CREATE MODEL can't register on remote model types, but ALTER MODEL can. In theory, no reason to register an already deployed model endpoint. |
TrevorBergeron
pushed a commit
that referenced
this pull request
Mar 20, 2024
* fix: exclude remote models for .register() * fix mypy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix!: exclude remote models for .register() (#465)
Release-As: 0.26.0
END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕