feat: add ml.llm.GeminiTextGenerator model#370
Conversation
ashleyxuu
left a comment
There was a problem hiding this comment.
Please add the GeminiTextGenerator model in the README.rst as well : https://github.com/googleapis/python-bigquery-dataframes/blob/main/README.rst?plain=1#L190
| "top_k": top_k, | ||
| "top_p": top_p, | ||
| "flatten_json_output": True, | ||
| } |
There was a problem hiding this comment.
I believe we don't give Python users the option to specify this flatten_json_output as we return a DataFrame format? I guess it is only applicable in SQL interface?
There was a problem hiding this comment.
right. It isn't user-facing, but what we send to SQL. It is always True value.
docs/templates/toc.yml
Outdated
| uid: bigframes.ml.llm.PaLM2TextGenerator | ||
| - name: PaLM2TextEmbeddingGenerator | ||
| uid: bigframes.ml.llm.PaLM2TextEmbeddingGenerator | ||
| - name: GeminiTextGenerator |
There was a problem hiding this comment.
Should be sorted it in alphabetic order.
Done |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕