Skip to content

Comments

chore: filter errors explicitly caught in BF dashboard#270

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
garrettwu-error
Dec 13, 2023
Merged

chore: filter errors explicitly caught in BF dashboard#270
gcf-merge-on-green[bot] merged 2 commits intomainfrom
garrettwu-error

Conversation

@GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Dec 12, 2023 •
edited by tswast
Loading

plx script change

Line 44 - 49: +

AND (configuration.labels.label IS NULL
  OR (
    SELECT l.value
      FROM UNNEST(configuration.labels.label) AS l
      WHERE l.key = "error_caught"
  ) != "True"))

@GarrettWu GarrettWu requested a review from ashleyxuu December 12, 2023 23:42
@GarrettWu GarrettWu requested review from a team as code owners December 12, 2023 23:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 12, 2023
@GarrettWu GarrettWu added the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 80b8bbe into main Dec 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-error branch December 13, 2023 00:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GarrettWu @ashleyxuu