Skip to content

fix: dataframes to_gbq now creates dataset if it doesn't exist#222

Merged
Genesis929 merged 11 commits intomainfrom
b295247521-to-gbq-create-dataset
Dec 18, 2023
Merged

fix: dataframes to_gbq now creates dataset if it doesn't exist#222
Genesis929 merged 11 commits intomainfrom
b295247521-to-gbq-create-dataset

Conversation

@Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Nov 18, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/295247521🦕

@Genesis929 Genesis929 requested review from a team as code owners November 18, 2023 01:53
@Genesis929 Genesis929 requested a review from tswast November 18, 2023 01:53
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 18, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 18, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 18, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 21, 2023
@Genesis929 Genesis929 requested a review from shobsi December 7, 2023 19:23
shobsi
shobsi reviewed Dec 12, 2023
View reviewed changes
@Genesis929 Genesis929 requested a review from a team as a code owner December 12, 2023 21:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Dec 12, 2023
@Genesis929 Genesis929 force-pushed the b295247521-to-gbq-create-dataset branch from a36078c to a4a2e50 Compare December 12, 2023 22:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: l Pull request size is large. labels Dec 12, 2023
@Genesis929 Genesis929 removed request for a team and kweinmeister December 12, 2023 22:15
@Genesis929 Genesis929 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 12, 2023
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 12, 2023
@Genesis929 Genesis929 requested a review from shobsi December 12, 2023 23:19
@shobsi shobsi added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Dec 14, 2023
@Genesis929 Genesis929 merged commit bac62f7 into main Dec 18, 2023
@Genesis929 Genesis929 deleted the b295247521-to-gbq-create-dataset branch December 18, 2023 22:47
@release-please release-please bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Genesis929 @shobsi @bigframes-bot