feat!: add structured output for ai map, ai filter and ai join#1746
Merged
feat!: add structured output for ai map, ai filter and ai join#1746
Conversation
Contributor
|
The change only breaks pre-release features, so please add a |
chelsea-lin
approved these changes
May 19, 2025
Contributor
chelsea-lin
left a comment
There was a problem hiding this comment.
LGTM overall, with leaving two comments.
| @@ -244,8 +301,8 @@ def test_map_multimodel(session, gemini_flash_model): | |||
| ) | |||
| result = df.ai.map( | |||
Contributor
There was a problem hiding this comment.
nit: assert the results' columns are expected?
Contributor
Author
There was a problem hiding this comment.
I would refrain from doing that because the answer is not stable.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: add structured output for ai map, ai filter and ai join (#1746)
The metric shows that there are no recent external calls to our ai operators, this change should be safe.
Also added:
logprobwill be available as an output if the user wants to check them.BREAKING CHANGE: the updated
ai.map()parameter list is not backward-compatibleRelease-As: 2.5.0
END_COMMIT_OVERRIDE