Conversation
added 2 commits
October 26, 2023 06:38
…es into b297352026-get-dummies
shobsi
reviewed
Oct 26, 2023
shobsi
reviewed
Oct 26, 2023
shobsi
reviewed
Oct 26, 2023
shobsi
reviewed
Oct 26, 2023
shobsi
reviewed
Oct 26, 2023
added 6 commits
October 27, 2023 16:51
…es into b297352026-get-dummies
…-bigquery-dataframes into b297352026-get-dummies
Contributor
Author
|
Thanks for the review! Working on addressing these comments today. |
TrevorBergeron
approved these changes
Nov 1, 2023
Contributor
TrevorBergeron
left a comment
There was a problem hiding this comment.
Logic looks good, just a few suggestions on cutting down the method length a bit
added 4 commits
November 1, 2023 17:09
…es into b297352026-get-dummies
…-bigquery-dataframes into b297352026-get-dummies
ashleyxuu
pushed a commit
that referenced
this pull request
Nov 1, 2023
* feat: add pd.get_dummies * remove unneeded prefix case * param/documentation fixes * be stricter about types in test * be stricter about types in series test * remove unneeded comment * adjust for type difference in pandas 1 * add example code (tested) * fix None columns and add test cases * variable names and _get_unique_values per-column * account for pandas 1 behavior difference * remove already_seen set * avoid unnecessary join/projection * fix column ordering edge case * adjust for picky examples checker * example tweak * make part of the example comments * use ellipsis in doctest comment * add <BLANKLINES> to doctest string * extract parameter standardization * extract submethods --------- Co-authored-by: Henry J Solberg <henryjsolberg@google.com>
ashleyxuu
pushed a commit
that referenced
this pull request
Nov 1, 2023
* feat: add pd.get_dummies * remove unneeded prefix case * param/documentation fixes * be stricter about types in test * be stricter about types in series test * remove unneeded comment * adjust for type difference in pandas 1 * add example code (tested) * fix None columns and add test cases * variable names and _get_unique_values per-column * account for pandas 1 behavior difference * remove already_seen set * avoid unnecessary join/projection * fix column ordering edge case * adjust for picky examples checker * example tweak * make part of the example comments * use ellipsis in doctest comment * add <BLANKLINES> to doctest string * extract parameter standardization * extract submethods --------- Co-authored-by: Henry J Solberg <henryjsolberg@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.