#1577: allow logging protobuf entries#1661
Merged
tseaver merged 4 commits intogoogleapis:logging-apifrom Mar 26, 2016
tseaver:1577-logging-protobuf_load_dump
Merged
#1577: allow logging protobuf entries#1661tseaver merged 4 commits intogoogleapis:logging-apifrom tseaver:1577-logging-protobuf_load_dump
tseaver merged 4 commits intogoogleapis:logging-apifrom
tseaver:1577-logging-protobuf_load_dump
Conversation
Contributor
Author
|
Python 3.4 test failure is due to protocolbuffers/protobuf#1352. I will work around by using a different message type. |
Contributor
Author
| :type message: Protobuf message | ||
| :param message: the message to be logged | ||
| """ | ||
| Parse(json.dumps(self.payload), message) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM pending docstring update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add a helper to parse an entry's payload into a protobuf message object.
Closes #1577