Documentation: Filtering Query by key is also possible.#1632
Merged
dhermes merged 2 commits intogoogleapis:masterfrom Mar 18, 2016
mgilson:patch-2
Merged
Documentation: Filtering Query by key is also possible.#1632dhermes merged 2 commits intogoogleapis:masterfrom mgilson:patch-2
dhermes merged 2 commits intogoogleapis:masterfrom
mgilson:patch-2
Conversation
Update the documentation for `add_filter` to make it clear that filtering by key is also possible.
Fixup for lint.
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Mar 18, 2016
Documentation: Filtering Query by key is also possible.
Contributor
|
Thanks @mgilson. In the future, if possible, can you squash your changes into a single commit? I'd be happy to help show you how if the need arises (e.g. here the |
Contributor
Author
|
@dhermes Sure. Sorry about that. I would have squashed it on this one, but I was doing all of my edits via the github editor and didn't realize the error until travis yelled at me. I wanted to make sure travis was happy with the second commit before I rebased and force-pushed -- But by the time I got back, you had already merged. |
Contributor
|
No worries. I didn't want to burden you with having a checkout. I appreciate the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the documentation for
add_filterto make it clear that filtering by key is also possible.