Add 'Sink.create' API wrapper and 'Client.sink' factory.#1596
Merged
tseaver merged 1 commit intogoogleapis:logging-apifrom Mar 11, 2016
tseaver:logging-sink_create
Merged
Add 'Sink.create' API wrapper and 'Client.sink' factory.#1596tseaver merged 1 commit intogoogleapis:logging-apifrom tseaver:logging-sink_create
tseaver merged 1 commit intogoogleapis:logging-apifrom
tseaver:logging-sink_create
Conversation
| return Logger(name, client=self) | ||
|
|
||
| def sink(self, name, filter_, destination): | ||
| """Creates a sink bound to the current client. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Mostly looks good but
|
gcloud/logging/client.py
Outdated
| """ | ||
| return Logger(name, client=self) | ||
|
|
||
| <<<<<<< HEAD |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM pending Travis. Squash if it pleases you. I have found it quite easy in my workflow to do: $ git checkout branch-working-on
$ git reset HEAD^
$ # Repeat for as many commits need to be squashed
$ git add -p . # I make sure I am adding the right stuff
$ git commit --amend # Just save itand then the amend will add back the staged contents to the original base commit. |
Contributor
Author
|
Squashed. I will merge after Travis passes. |
Contributor
Author
|
I've been using |
tseaver
added a commit
that referenced
this pull request
Mar 11, 2016
Add 'Sink.create' API wrapper and 'Client.sink' factory.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* feat: add generator option proto-plus-dep * fix mypy * fix style * update goldens * fix tests * clean up * clean up * add support for dependency google-cloud-kms * Address review comments * add missing file * run formatting tool * style * address review comments * formatting * address review feedback * style * add pypi package google-geo-type * bump google-cloud-documentai dependency to 2.0.0 * address review comment * add docstring * address review comment * fix docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR punts on any answer to #1591.