Merged
Conversation
nathanielmanistaatgoogle
approved these changes
Nov 1, 2016
Contributor
nathanielmanistaatgoogle
left a comment
There was a problem hiding this comment.
I approve; leaving unmerged in case @jonparrott spots anything in his review.
Contributor
85276d8 to
f397357
Compare
Author
|
@jonparrott Done. PTAL |
Contributor
|
LGTM On Tue, Nov 1, 2016, 5:04 PM Brian J. Watson notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nathanielmanistaatgoogle @jonparrott Most of this change is regenerating the docs using the
docs/buildscript. The rest is just adding to the CHANGELOG, and bumping the version in__init__.py.I just did this as a point release, but can make it a minor release if you think adding a keyword arg to media upload methods qualifies as "adding new functionality".