Pass database_id from GetInstance() down to CreateFirestore()#1270
Merged
milaGGL merged 4 commits intomila/MultiDBfrom Apr 14, 2023
Merged
Pass database_id from GetInstance() down to CreateFirestore()#1270milaGGL merged 4 commits intomila/MultiDBfrom
milaGGL merged 4 commits intomila/MultiDBfrom
Conversation
milaGGL
commented
Apr 13, 2023
milaGGL
commented
Apr 13, 2023
milaGGL
commented
Apr 13, 2023
tom-andersen
requested changes
Apr 14, 2023
❌ Integration test FAILEDRequested by @milaGGL on commit 6a9e36b
Add flaky tests to go/fpl-cpp-flake-tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing database_id as an additional parameter all the way down to iOS
CreateFirestorefunction.Passing the database_id parameter only, no implementation change yet.