Fix custom hook methods for typed client#3640
Open
laurensiusadi wants to merge 1 commit intofeathersjs:dovefrom
Open
Fix custom hook methods for typed client#3640laurensiusadi wants to merge 1 commit intofeathersjs:dovefrom
laurensiusadi wants to merge 1 commit intofeathersjs:dovefrom
Conversation
Filter hook methods to include only those that are functions to prevent error "Can not apply hooks" in the typed client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building typed client from backend, if any service have custom methods on it, the client typescript will pick up as error "Can not apply hooks".
To fix this issue I added filtering to make sure the method is available as function.
I ran this feathers locally, bundle client, and test it on client, it works as a fix.
Fixes issue #3576